git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH][GSoC] submodule: introduce add-clone helper for submodule add

From
Atharva Raykar <raykar.ath@gmail.com>
Date
Jun 2, 2021, 08:18 UTC
Message-ID
<44C3C05A-1BA8-42BF-8614-1BA859050AEE@gmail.com>
In-Reply-To
<38AEA0B4-FCF7-4123-9412-98C1394972B0@gmail.com>
Show 22 quoted lines
> On 02-Jun-2021, at 13:25, Atharva Raykar <raykar.ath@gmail.com> wrote:
> 
> [...]
> I've not yet fully developed a taste for good C style, so I wanted
> to ask, which one looks better to you in these?
> 
> /* Sample 1 */
> while (begin != end && (line = get_next_line(begin, end))) {
> 	char *name, *url, *tail;
> 	name = parse_token(&begin, next_line);
> 	url = parse_token(&begin, next_line);
> 	tail = parse_token(&begin, next_line);
> 	...
> }
> 
> /* Sample 2 */
> while (begin != end && (line = get_next_line(begin, end))) {
> 	char *name = parse_token(&begin, next_line);
> 	char *url = parse_token(&begin, next_line);
> 	char *tail = parse_token(&begin, next_line);
> 	...
> }

Also ignore the error here, assume: s/next_line/line/ (Anyway, my question was about style)

Previous: Atharva RaykarNext: Atharva Raykar
Message 4 of 11 in “[GSoC] submodule: introduce add-clone helper for submodule add”
  1. [GSoC] submodule: introduce add-clone helper for submodule addAtharva Raykar, May 28, 2021
  2. Christian CouderJun 1, 2021
  3. Atharva RaykarJun 2, 2021
  4. Atharva RaykarJun 2, 2021
  5. [GSoC] submodule--helper: introduce add-clone subcommandAtharva Raykar, Jun 2, 2021
  6. Christian CouderJun 4, 2021
  7. Atharva RaykarJun 4, 2021
  8. [GSoC] submodule--helper: introduce add-clone subcommandAtharva Raykar, Jun 4, 2021
  9. Atharva RaykarJun 4, 2021
  10. Shourya ShuklaJun 4, 2021
  11. Atharva RaykarJun 4, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.