git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] format-patch: Generate a newline between the subject header and the message body.

From
RSRobert Shearman <rob@codeweavers.com>
Date
Jul 13, 2006, 21:55 UTC
Message-ID
<44B6C152.8000204@codeweavers.com>
In-Reply-To
<7v7j2huqfj.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano wrote:
Show 30 quoted lines
>Junio C Hamano <junkio@cox.net> writes:
>
>  
>
>>Robert Shearman <rob@codeweavers.com> writes:
>>
>>    
>>
>>>This patch inserts a newline in two places - once in the loop to
>>>separate the subject part of the commit message from the body part of
>>>the commit message and another after the loop to counteract the eating
>>>of whitespace at the end of the message.
>>>      
>>>
>>Thanks.
>>
>> * Please sign your patch.
>>
>> * This breaks a handful t4013 tests, but all in a good way (in
>>   other words, the expected output files were wrong).
>>
>>I'll fix up the t/t4013/diff.* files myself.
>>    
>>
>
>Actually, I take that back.  This breaks normal commit log
>messages by adding extra blank lines.  The extra LF is needed
>when the commit log does not have any message (just title).
>  
>
Ok, I'll resend with that fixed.
>I'll be tweaking a few tests in t4013 to catch future breakage
>of this kind.
>
Thanks.
-- 
Rob Shearman
Previous: Junio C Hamano
Message 6 of 6 in “format-patch: Generate a newline between the subject header and the message body.”
  1. format-patch: Generate a newline between the subject header and the message body.Robert Shearman, Jul 13, 2006
  2. Jakub NarebskiJul 13, 2006
  3. Robert ShearmanJul 13, 2006
  4. Junio C HamanoJul 13, 2006
  5. Junio C HamanoJul 13, 2006
  6. Robert ShearmanJul 13, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.