Re: Issues with git clone over HTTP/2 and closed connections

From: David Härdeman <david@hardeman.nu>
Date: Sep 24, 2023, 14:47 UTC
Message-ID: <4454d8e1dab565118a316409d653844bbbfacfc7@hardeman.nu>
In-Reply-To: <20230924035022.GA1503477@coredump.intra.peff.net>

September 24, 2023 at 5:50 AM, "Jeff King" <peff@peff.net> wrote:

Show 18 quoted lines

> On Sat, Sep 23, 2023 at 12:58:09PM +0000, David Härdeman wrote:
>> From what I understand, git should close the connection, try to open a
>>  new one and resume the clone operation before erroring out (because
>>  the GOAWAY message could mean anything).
>>  
>>  Is this a known bug and is it something that would need to be fixed in
>>  libcurl or in git?
>> 
> 
> I don't think we've heard of such a problem before with Git. I don't
> know enough about GOAWAY to comment on the correct behavior, but this is
> almost certainly a curl issue, not a Git one. All of the connection
> handling, reuse, etc, is happening invisibly at the curl layer.
> 
> It's probably worth poking around libcurl's issue tracker. This seems
> like it might be related:
> 
>  https://github.com/curl/curl/issues/11859

Yeah, looks very relevant. I'll keep an eye on that issue instead.

Thanks for the prompt feedback.

Show 5 quoted lines

> And one final comment: 2000 is a lot of requests for one clone. That
> plus the error you are seeing from Git makes me think you're using the
> "dumb" http protocol (i.e., your webserver is not set up to run the
> server side of Git's smart protocol, so it is just serving files
> blindly).

Yeah, thanks for the advice...I've already sorted this out so that I'm not affected, but I wanted to make sure that I posted the bug report before I forgot all the details.

Cheers, David