Re: [PATCH] ci: add job for gcc-4.8 to GitHub Actions

From: Derrick Stolee <stolee@gmail.com>
Date: Aug 16, 2021, 16:06 UTC
Message-ID: <444e7410-c9c9-1b90-da5f-d6862a35c1fc@gmail.com>
In-Reply-To: <20210816045750.36499-1-carenas@gmail.com>

On 8/16/2021 12:57 AM, Carlo Marcelo Arenas Belón wrote:

Show 18 quoted lines

> unlike the other jobs; using an older ubuntu base image that provides
> that compiler as an option.
> 
> note the obsoleted travis job used an image of the OS that is EOL and
> therefore not available, but the compiler used will be the same, and
> more importantly will fail in the same (C89 compatibility) issues.
> 
> Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
> ---
> based on top of my tip for cb/reftable-fixes, but applies cleanly all
> the way to maint.
> 
> a succesful run can be seen in:
> 
>   https://github.com/carenas/git/runs/3336674183
> 
> it adds 2m to the current setup, but gcc 4.8 is hard to find in modern
> developer workstations (or even non EOL enterprise systems)

Forgive me, I probably missed a discussion about this somewhere else on the list, but...

Could you describe why we want GCC 4.8 in our CI? Is that a compiler version that we officially support? What kind of syntax triggers a problem on 4.8 versus latest?

Show 11 quoted lines

> diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
> index 73856bafc9..0f211173fc 100644
> --- a/.github/workflows/main.yml
> +++ b/.github/workflows/main.yml
> @@ -297,6 +297,9 @@ jobs:
>            - jobname: linux-gcc-default
>              cc: gcc
>              pool: ubuntu-latest
> +          - jobname: linux-gcc-4.8
> +            cc: gcc-4.8
> +            pool: ubuntu-18.04

Makes sense.

Show 20 quoted lines

>      env:
>        CC: ${{matrix.vector.cc}}
>        jobname: ${{matrix.vector.jobname}}
> diff --git a/ci/install-dependencies.sh b/ci/install-dependencies.sh
> index 67852d0d37..950bc39129 100755
> --- a/ci/install-dependencies.sh
> +++ b/ci/install-dependencies.sh
> @@ -72,10 +72,14 @@ Documentation)
>  	test -n "$ALREADY_HAVE_ASCIIDOCTOR" ||
>  	sudo gem install --version 1.5.8 asciidoctor
>  	;;
> -linux-gcc-default|linux-gcc-4.8)
> +linux-gcc-default)
>  	sudo apt-get -q update
>  	sudo apt-get -q -y install $UBUNTU_COMMON_PKGS
>  	;;
> +linux-gcc-4.8)
> +	sudo apt-get -q update
> +	sudo apt-get -q -y install $UBUNTU_COMMON_PKGS gcc-4.8
> +	;;

Interesting that we already had a case here. Is there interesting history about this prior-existing case that might be illuminating to the current need?

Thanks, -Stolee