git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Ignore commits for which cvsps can't identify a branch

From
CBChristian Biesinger <cbiesinger@web.de>
Date
Feb 10, 2006, 22:02 UTC
Message-ID
<43ED0D63.5090105@web.de>
In-Reply-To
<7vmzgyvrih.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano wrote:
Show 5 quoted lines
> Does continuing with this kind of "fixups" produce usable
> history, perhaps just some changes missing but trees contained
> in other commits are still faithful reproductions of what the
> CVS repository would have given you?  Or does it result in
> unusable history?

I have to admit that I can't actually tell you for sure, since I still get a failure later (I think it's because cvsps orders changesets wrongly). However, I was told that the revisions that give me this CVSPS_NO_BRANCH issue came into existence by (partially) removing tags from a file, so not listing them should be fine, I think. (This happened by copying a ,v file and removing its tags, simulating a file copy)

Anyway, based on that, I expect that the history is the same as what I get from cvs, but I can't verify that.

> Depending on the nature of corruption and its expected use,
> sometimes silently corrupt conversion result is worse than not
> having it at all.

Well, without the patch this error is fatal, and the conversion is very partial. I'm not sure if that's better.

(This is also not "silent" corruption. I do show a message for it. Would you rather have it displayed unconditionally?)

Would it be better to have a flag --continue-on-errors?
Previous: Junio C HamanoNext: Linus Torvalds
Message 3 of 6 in “Ignore commits for which cvsps can't identify a branch”
  1. Ignore commits for which cvsps can't identify a branchChristian Biesinger, Feb 10, 2006
  2. Junio C HamanoFeb 10, 2006
  3. Christian BiesingerFeb 10, 2006
  4. Linus TorvaldsFeb 10, 2006
  5. Yann DirsonJun 10, 2006
  6. Christian BiesingerJun 10, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.