Re: [PATCH] stgit: fix clone
- From
- Chuck Lever <cel@citi.umich.edu>
- Date
- Jan 12, 2006, 14:51 UTC
- Message-ID
- <43C66CE5.1050009@citi.umich.edu>
- In-Reply-To
- <b0943d9e0601120354u73489c74j@mail.gmail.com>
Catalin Marinas wrote:
Show 22 quoted lines
> On 11/01/06, Chuck Lever <cel@citi.umich.edu> wrote:
>
>>Chuck Lever wrote:
>>
>>>seems to me the "git clone" script should create an environment where
>>>"git-rev-parse --git-dir" ought to work correctly.
>>
>>stgit/main.py does a special stack.Series('master') just for the clone
>>command. it really shouldn't do this -- the crt_series.init() in the
>>clone command ought to be fixed to do this properly.
>
>
> If the stack.Series() doesn't get a parameter, it will try to get the
> default branch using 'git-symbolic-ref HEAD'. Any command run outside
> a tree (and which doesn't have the -h option) would fail. The clone
> command is the only one allowed to run outside a tree and that's why I
> passed a default branch name. This is to avoid the creation of another
> stack.Series() object later when the git tree was cloned.
>
> See the attached patch for a different fix and let me know if there
> are any issues with it. I should probably release 0.8.1 with the fixed
> bugs.looked at the patch. that's what i had in mind. the extra exception processing in Series.__init__ is a nice touch.
begin:vcard fn:Chuck Lever n:Lever;Charles org:Network Appliance, Incorporated;Open Source NFS Client Development adr:535 West William Street, Suite 3100;;Center for Information Technology Integration;Ann Arbor;MI;48103-4943;USA email;internet:cel@citi.umich.edu title:Member of Technical Staff tel;work:+1 734 763-4415 tel;fax:+1 734 763 4434 tel;home:+1 734 668-1089 x-mozilla-html:FALSE url:http://troy.citi.umich.edu/u/cel/ version:2.1 end:vcard