git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 5/5] Recent MinGW has a C99 implementation of snprintf functions

From
Johannes Sixt <j6t@kdbg.org>
Date
May 20, 2010, 18:57 UTC
Message-ID
<439f0b3d51f9548b72e0e719d590cc9bcf4c0084.1274380838.git.j6t@kdbg.org>
In-Reply-To
<cover.1274380838.git.j6t@kdbg.org>
Date: Mon, 20 Jul 2009 22:15:07 +0200

Starting with MinGW 3.14, released end of 2007, a working snprintf is available. This means we do not need our own replacement that works around the broken implementation in Microsoft's C runtime.

People who build git in an old MinGW environment are expected to set SNPRINTF_RETURNS_BOGUS in their config.mak. msysgit is sufficiently recent, of course.

Signed-off-by: Johannes Sixt <j6t@kdbg.org>
---
 The Date: line is deliberate to show how long I carry this patch. :-)
 Makefile |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/Makefile b/Makefile
index 910f471..c36c5b0 100644
--- a/Makefile
+++ b/Makefile
@@ -1026,7 +1026,6 @@ ifneq (,$(findstring MINGW,$(uname_S)))
 	NO_STRTOUMAX = YesPlease
 	NO_MKDTEMP = YesPlease
 	NO_MKSTEMPS = YesPlease
-	SNPRINTF_RETURNS_BOGUS = YesPlease
 	NO_SVN_TESTS = YesPlease
 	NO_PERL_MAKEMAKER = YesPlease
 	RUNTIME_PREFIX = YesPlease
-- 
1.7.1.64.ga1799.dirty
Previous: Johannes SixtNext: Junio C Hamano
Message 6 of 7 in “Various fixes for Windows”
  1. 0/5 Various fixes for WindowsJohannes Sixt, May 20, 2010
  2. 1/5 Fix "Out of memory? mmap failed" for files larger than 4GB on WindowsJohannes Sixt, May 20, 2010
  3. 2/5 start_command: close cmd->err descriptor when fork/spawn failsJohannes Sixt, May 20, 2010
  4. 3/5 Fix checkout of large files to network shares on Windows XPJohannes Sixt, May 20, 2010
  5. 4/5 mingw: use _commit to implement fsyncJohannes Sixt, May 20, 2010
  6. 5/5 Recent MinGW has a C99 implementation of snprintf functionsJohannes Sixt, May 20, 2010
  7. Junio C HamanoMay 20, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.