Re: gitweb on kernel.org and UTF-8

From: H. Peter Anvin <hpa@zytor.com>
Date: Nov 23, 2005, 00:59 UTC
Message-ID: <4383BEE4.1060800@zytor.com>
In-Reply-To: <7vzmnw9qo0.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano wrote:

Show 29 quoted lines

> Is it possible that the UTF-8 check in gitweb running on
> kernel.org machine is somehow too strict?
> 
> The following two commits in git.git repository are not showing
> properly.
> 
> I have a track record of getting peoples' names wrong, so I
> double checked my commit objects, and as far as I can tell, all
> of them are encoded in UTF-8 properly (or at least I can view
> what I expect if I throw raw bytes from the commit objects at my
> Firefox):
> 
>         c3df8568424684bbcc7df7722eb3ec34bdae8b2d
> 
>         This is from Yoshifuji-san; the third character in
>         author name field is mangled.
> 
> 	bb931cf9d73d94d9940b6d0ee56b6c13ad42f1a0
> 
> 	This is from Lukas Sandstr*m; o with Umlaut on top is
> 	showing a ?.  Incidentally, the blob that records recent
> 	version of Documentation/git-pack-redundant.txt has his
> 	name in it, which has the same ? problem, but "plain"
> 	option shows his name correctly in UTF-8.
> 
> Interestingly enough, my name spelled in Japanese
> (Documentatino/git-lost-found.txt) is intact.  Am I getting a
> VIP treatment somehow?
>

I think it's missing a "binmode STDOUT, ':utf8';" somewhere...

For what it's worth, I looked at both the above examples and the binary encoding in the git repository is undoubtedly correct; the two characters are U+82F1/E8 8B B1 (英) and U+00F6/C3 B6 (ö) respectively, both of which are 100% valid UTF-8.

	-hpa