Re: [PATCH] Fix compilation of git.c

From: Andreas Ericsson <ae@op5.se>
Date: Nov 16, 2005, 06:54 UTC
Message-ID: <437AD7A6.6050906@op5.se>
In-Reply-To: <7v4q6de1oc.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano wrote:

Show 10 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> 
>>Some systems do not define GLOB_ABORTED and GLOB_NOMATCH.
> 
> 
> That's true, but the glob does not distinguish executables and
> others anyway, do wouldn't it be more portable and easier to do
> readdir, stat and list in the loop?
>

Got one implementation of that too, but it doesn't sort the command list and I thought it was nice to have them that way while too lazy to implement myself.

OTOH, that switch/case thing was for debugging (forgot prefix=/usr when compiling...). I'm perfectly fine with

if (glob(....)) {
	error_out("friendly message");
}

-- 
Andreas Ericsson                   andreas.ericsson@op5.se
OP5 AB                             www.op5.se
Tel: +46 8-230225                  Fax: +46 8-230231