Re: [PATCH] Small script to patch .spec for Suse

From: Andreas Ericsson <ae@op5.se>
Date: Nov 15, 2005, 21:56 UTC
Message-ID: <437A5975.3020705@op5.se>
In-Reply-To: <437A46E4.5010909@zytor.com>

H. Peter Anvin wrote:

Show 5 quoted lines

> 
> I'd prefer to have just @@OPENSSH_PACKAGE@@ and @@EXPAT_PACKAGE@@ 
> instead of completely virtualizing the dependencies.  Less flexible to 
> be sure, but it makes it less confusing to read and fix.
>

git doesn't, strictly speaking, require openssh, for two reasons; a. It's been known to work equally well over rsh. b. ssh is run as an executed command. ssh can be installed later and the previously installed git will start working just like magic.

If you really *want* an openssh requirement, you should just go with
Requires: /usr/bin/ssh
It's the most accurate one after all, since git doesn't really care 
which package it came from so long as it's there.

As for BuildRequires, I think package maintainers can be trusted to figure those out for themselves. It's not as if they'll be producing flawed RPM's after all.

If you want one for expat anyways, then go with
BuildRequires: expat
since that's true for both dists (and FC maintainers will then happily 
figure out that they need expat-devel to build it).

-- 
Andreas Ericsson                   andreas.ericsson@op5.se
OP5 AB                             www.op5.se
Tel: +46 8-230225                  Fax: +46 8-230231