Re: [PATCH] Building git on NetBSD

From: Andreas Ericsson <ae@op5.se>
Date: Nov 12, 2005, 15:32 UTC
Message-ID: <43760AF5.1010704@op5.se>
In-Reply-To: <Pine.LNX.4.64.0511120649430.2695@x2.ybpnyarg>

walt wrote:

Show 6 quoted lines

> 
> I'm no software developer so I'm not sure about the syntax of the -rpath
> flag.  It does what I wanted, but it results in lots of warnings about
> not being used because no linking is taking place.  Should this maybe
> go in LDFLAGS instead of CFLAGS?  Dunno.
>

Yes it should. Currently the git makefile doesn't distinguish between CFLAGS and LDFLAGS which results in a fair few warnings.

Show 5 quoted lines

> Oh, one person was concerned about the cogito scripts running on the
> NetBSD version of sh, which isn't bash.  So far I've tried cg-clone,
> cg-update, and gitk, and all worked just like on linux.  Any chance
> that some of the other scripts may not work as well on a non-bash sh?
>

gitk is in tcl so I'd be surprised if that didn't work.

I don't think there's been a whole lot of testing for other shells but the friendly folks on this list usually takes care of fixing such things fairly quickly so long as someone tells them where to look or, preferrably, sends a patch that does the trick.

-- 
Andreas Ericsson                   andreas.ericsson@op5.se
OP5 AB                             www.op5.se
Tel: +46 8-230225                  Fax: +46 8-230231