git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] xdiff: trim common tail with -U0 after diff

From
Daniel Hahler <git@thequod.de>
Date
Jun 23, 2017, 22:57 UTC
Message-ID
<436f31fb-3a06-e6ca-094e-8e92aa1ee1d1@thequod.de>
In-Reply-To
<fa350688-1831-f979-b984-3b6d54e32b8c@web.de>
On 23.06.2017 22:39, René Scharfe wrote:
> The changed test script passes just fine for me even without your change
> to xdiff-interface.c, which is odd.
Sorry, I've apparently messed this up - it seems to be the case for me, too.
I would assume that using the functions.c context/diff in this test file might prove it, but when I wrote this test I was already unsure to base it on an experimental feature, that might just get removed again (with its tests).
> Do you have another way to demonstrate the unexpected behavior?
It was clearly reproducible with a local test case, based on "copying an existing test case, and modifying the header for it only".

Given the other replies, it seems like it is more a question now if the trimming should get moved down, or removed completely it seems. So I will not update the patch/test for now.

-- 
http://daniel.hahler.de/
Previous: René Scharfe
Message 6 of 6 in “xdiff: trim common tail with -U0 after diff”
  1. xdiff: trim common tail with -U0 after diffDaniel Hahler, Jun 23, 2017
  2. Junio C HamanoJun 23, 2017
  3. Stefan BellerJun 23, 2017
  4. Junio C HamanoJun 23, 2017
  5. René ScharfeJun 23, 2017
  6. Daniel HahlerJun 23, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.