Re: [PATCH] git-daemon extra paranoia
- From
- H. Peter Anvin <hpa@zytor.com>
- Date
- Oct 18, 2005, 21:29 UTC
- Message-ID
- <4355691D.2010200@zytor.com>
- In-Reply-To
- <7vll0qploy.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano wrote:
> > I would understand rejecting /../, and perhaps /./, but why > reject // in between or / at the end? >
For security, avoiding aliases is highly desirable, and if they're useless the easiest way to do that is to reject. If aliases are required, which it sounds like it might be, then canonicalization needs to be applied.
This may sound redundant, but a lot of avoiding security holes involves applying good practices up front, instead of reactively.
Allowing a terminal slash should be reasonably easy, though.
-hpa