Re: [PATCH 3/4] object-name: reject trees found in the index
- From
Derrick Stolee <derrickstolee@github.com>
- Date
- Apr 18, 2022, 12:31 UTC
- Message-ID
- <4344a533-8450-1e05-3d4e-642eda330af2@github.com>
- In-Reply-To
- <Ylhui1cBGDca4m19@google.com>
On 4/14/2022 2:57 PM, Josh Steadmon wrote:
> On 2022.04.07 16:37, Derrick Stolee via GitGitGadget wrote: >> From: Derrick Stolee <derrickstolee@github.com>
>> This changes the behavior of 'git show :<sparse-dir>', but does not >> bring it entirely into alignment with a full index case. It specifically >> hits the wrong error message within diagnose_invalid_index_path(). That >> error message will be corrected in a future change.
...
Show 8 quoted lines
>> + test_must_fail git -C sparse-index show :folder1/ 2>err && >> + grep "is in the index, but not at stage 0" err >> ' > > It might be worth a note that we're demonstrating the current behavior > here, but this is not the desired end-state. In other words, explicitly > note that this is the "wrong error message" referred to in the commit > message.
This is mentioned in the commit message. Since the line will be changed in the next patch, I didn't think a test comment was worth it.
Thanks, -Stolee