Re: Honor extractor's umask in git-tar-tree.

From: H. Peter Anvin <hpa@zytor.com>
Date: Oct 3, 2005, 18:05 UTC
Message-ID: <434172FD.7020302@zytor.com>
In-Reply-To: <Pine.LNX.4.64.0510031028370.31407@g5.osdl.org>

Linus Torvalds wrote:

Show 8 quoted lines

> 
> As to tar: I think the current
> 
>         if (S_ISDIR(mode) || S_ISREG(mode))
>                 mode |= (mode & 0100) ? 0777 : 0666;
> 
> is wrong. It makes things world-writable by default, and that's just 
> dangerous.

That's standard in the Unix world, though; of course, the user's umask shouldn't be set to zero unless things are in very special circumstances. In the case of tar, the umask is applied on extraction unless the user explicitly specifies -p.

	-hpa