git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Fix git-init-db creating crap directories

From
HAH. Peter Anvin <hpa@zytor.com>
Date
Sep 20, 2005, 00:09 UTC
Message-ID
<432F5345.3020303@zytor.com>
In-Reply-To
<20050920000731.GJ18320@pasky.or.cz>
Petr Baudis wrote:
Show 11 quoted lines
> diff --git a/init-db.c b/init-db.c
> --- a/init-db.c
> +++ b/init-db.c
> @@ -153,7 +153,8 @@ static void copy_templates(const char *g
>  		return;
>  	}
>  
> -	memcpy(path, git_dir, len);
> +	memcpy(path, git_dir, len-1);
> +	path[len] = 0;
>  	copy_templates_1(path, len,
Wrong!  You're not initializing path[len-1]!
	-hpa
Previous: Petr BaudisNext: Petr Baudis
Message 17 of 22 in “Garbage in .git directories???”
  1. Dmitry TorokhovSep 18, 2005
  2. Linus TorvaldsSep 18, 2005
  3. Dmitry TorokhovSep 18, 2005
  4. Dmitry TorokhovSep 19, 2005
  5. Junio C HamanoSep 19, 2005
  6. Linus TorvaldsSep 19, 2005
  7. Dmitry TorokhovSep 19, 2005
  8. Dmitry TorokhovSep 20, 2005
  9. Linus TorvaldsSep 20, 2005
  10. Dmitry TorokhovSep 20, 2005
  11. H. Peter AnvinSep 19, 2005
  12. Petr BaudisSep 19, 2005
  13. H. Peter AnvinSep 19, 2005
  14. Petr BaudisSep 19, 2005
  15. H. Peter AnvinSep 19, 2005
  16. Fix git-init-db creating crap directoriesPetr Baudis, Sep 20, 2005
  17. H. Peter AnvinSep 20, 2005
  18. Fix git-init-db creating crap directories (zeroth try)Petr Baudis, Sep 20, 2005
  19. H. Peter AnvinSep 20, 2005
  20. Petr BaudisSep 20, 2005
  21. Junio C HamanoSep 20, 2005
  22. H. Peter AnvinSep 20, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.