git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Remove shell dependency in env.c

From
HAH. Peter Anvin <hpa@zytor.com>
Date
Sep 15, 2005, 16:30 UTC
Message-ID
<4329A1BE.60600@zytor.com>
In-Reply-To
<7vy85yahjk.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano wrote:
Show 13 quoted lines
> "H. Peter Anvin" <hpa@zytor.com> writes:
> 
> 
>>This patch adds an invocation of "env", so rsh.c works for C-shell users 
>>as well as Bourne shell users.
> 
> 
> Hmph.  I think the original code is buggy already.  If the path
> has a single quote in it, you would get into a problem.  If the
> remote end first interprets what is given to it with C-shell,
> then it probably would also barf if path had a '!' in it, too,
> even though we quote the entire thing within a single-quote
> pair.

True. The better method is to \-escape any questionable characters, instead of trying to use quotes. I'll try to write that up.

	-hpa
Previous: Junio C HamanoNext: H. Peter Anvin
Message 3 of 12 in “Remove shell dependency in env.c”
  1. Remove shell dependency in env.cH. Peter Anvin, Sep 15, 2005
  2. Junio C HamanoSep 15, 2005
  3. H. Peter AnvinSep 15, 2005
  4. Shell quotingH. Peter Anvin, Sep 15, 2005
  5. Linus TorvaldsSep 15, 2005
  6. H. Peter AnvinSep 15, 2005
  7. Junio C HamanoSep 15, 2005
  8. H. Peter AnvinSep 15, 2005
  9. Junio C HamanoSep 15, 2005
  10. Linus TorvaldsSep 15, 2005
  11. Junio C HamanoSep 16, 2005
  12. rsh.c env and quoting cleanup, take 2H. Peter Anvin, Sep 15, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.