Re: [PATCH] filter-branch: really allow running in a bare repository
- From
- Eric Kidd <emk.lists@randomhacks.net>
- Date
- Feb 3, 2009, 19:31 UTC
- Message-ID
- <431341160902031131s63f34665ne9db25d8a4d1f0f9@mail.gmail.com>
- In-Reply-To
- <alpine.DEB.1.00.0902031910001.9822@pacific.mpi-cbg.de>
On Tue, Feb 3, 2009 at 1:10 PM, Johannes Schindelin <johannes.schindelin@gmx.de> wrote:
> When checking if running in a bare repository, the work tree has to be > reset, otherwise we will be checking the temporary state, which is > always non-bare.
Just a few minutes after you posted this patch, I posted a nearly-identical fix for the same issue:
http://marc.info/?l=git&m=123368695831812&w=2
(My patch includes a test case, too, but it's not very important.)
This raises another interesting question: Why doesn't 'git filter-branch' actually check whether subcommands succeed?
Cheers, Eric