Re: Commit 7c5977297f07c2a52c8c0f486309076b2a795d33 appears to have broken cg-init

From: Bryan Larsen <bryan.larsen@gmail.com>
Date: Jul 11, 2005, 04:01 UTC
Message-ID: <42D1EF33.2070000@gmail.com>
In-Reply-To: <20050711015820.GA16618@ca-server1.us.oracle.com>

Yes, I meant to use $ARGS.  I included the fix in the patchset I just sent.

Sorry, Bryan

Joel Becker wrote:

Show 29 quoted lines

> Petr,
> 	Commit 7c5977297f07c2a52c8c0f486309076b2a795d33 contains the
> chunk:
> 
> -uri=$1
> +
> +infoonly=
> +while optparse; do
> +	if optparse -N; then
> +		infoonly=-N
> +	else
> +		optfail
> +	fi
> +done
> +
> +uri=$ARGV
> 
> 	However, $ARGV is not a variable I've ever seen supported in a
> Bourne-like shell.  Certainly Bash supports BASH_ARGV, but not ARGV.
> 	The recent option parsing code adds ARGS in cg-Xlib, but not
> ARGV.
> 	The upshot is that a cg-clone/cg-init attempt thinks $uri is
> empty, and always creates an initial commit.  No clone.  I don't know
> how folks have gotten cg-clone rsync://linus to work since this change
> went in.
> 	I don't know what the proper solution is with the modern option
> code, but changing it back to 'url=$1' allows me to grab Linus' tree.
> 
> Joel