Re: [PATCH] Unset TZ in t5000

From: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>
Date: Jun 13, 2005, 15:54 UTC
Message-ID: <42ADAC4D.7050408@lsrfire.ath.cx>
In-Reply-To: <20050613002444.80848.qmail@web41213.mail.yahoo.com>

Mark Allen schrieb:

Show 5 quoted lines

> Unset TZ in t5000 and remove GNU awkism
> 
> The t5000 test script fails at test #4 on my box because my copy of 
> tar adjusts the time in the tarfile for local time if TZ is set. 
> Explicitly unset TZ so that it reports GMT time.

Good idea.

> Additionally, my version of AWK doesn't like the "length" directive, 
> so this patch removes it.

What kind of AWK is that? The One True AWK certainly has a length function for strings and POSIX mandates it, too, so it's not a GNUism.

The expression

   length($5)<7 ? $5":00" : $5

(where $5 is a time value) is there to cope with tars that format the time like hh:mm instead of the expected hh:mm:ss. If you have to remove the call to "length", please replace the thing with something equivalent, like

   match($5, /:.*:/) ? $5 : $5":00"

or similar, instead of simply dropping that test.

Thanks, Rene