Re: [PATCH] git-tar-tree: add a test case (resent)

From: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>
Date: Jun 3, 2005, 14:43 UTC
Message-ID: <42A06C96.8050107@lsrfire.ath.cx>
In-Reply-To: <Pine.LNX.4.58.0506030728120.1876@ppc970.osdl.org>

Linus Torvalds schrieb:

Show 7 quoted lines

> 	torvalds@ppc970:~> tar --version
> 	tar (GNU tar) 1.13.25
> 	Copyright © 2001 Free Software Foundation, Inc.
> 	This program comes with NO WARRANTY, to the extent permitted by law.
> 	You may redistribute it under the terms of the GNU General Public License;
> 	see the file named COPYING for details.
> 	Written by John Gilmore and Jay Fenlason.

[...]

Show 19 quoted lines

> I get
> 
> 	?rw------- git/git          52 1969-12-31 16:00:00 pax_global_header unknown file type `g'
> 	drwxr-xr-x git/git           0 2005-05-27 15:00:00 a/
> 	-rw-r--r-- git/git          18 2005-05-27 15:00:00 a/1.......10........20........30........40......481.......10........20........30........40........50
> 	?rw------- git/git         111 2005-05-27 15:00:00 37e07bc886b166ad2525f1cc7a2df9bda0e07a02.paxheader unknown file type `x'
> 	-rw-r--r-- git/git          18 2005-05-27 15:00:00 37e07bc886b166ad2525f1cc7a2df9bda0e07a02.data
> 	?rw------- git/git         112 2005-05-27 15:00:00 f72c8a14fa272506e5de2d779cfe088769158b61.paxheader unknown file type `x'
> 	-rw-r--r-- git/git          18 2005-05-27 15:00:00 f72c8a14fa272506e5de2d779cfe088769158b61.data
> 	?rw------- git/git         113 2005-05-27 15:00:00 b53ac87f1a63ea1a2eec65cc8b5bed9130b8c114.paxheader unknown file type `x'
> 	-rw-r--r-- git/git          18 2005-05-27 15:00:00 b53ac87f1a63ea1a2eec65cc8b5bed9130b8c114.data
> 	-rw-r--r-- git/git          16 2005-05-27 15:00:00 a/a
> 	drwxr-xr-x git/git           0 2005-05-27 15:00:00 a/bin/
> 	-rwxr-xr-x git/git      719924 2005-05-27 15:00:00 a/bin/sh
> 	tar: Unexpected EOF in archive
> 	tar: Error is not recoverable: exiting now
> 
> which doesn't tell me anything, except I assume it means that my tar 
> doesn't understand extended headers.

That's true, but you don't need them if all your pathes' lengths are 100 or shorter. Of course the test exercising long paths will always fail with your version of tar. I should split it out better, so you will at least get a positive result for short paths. I just didn't expect such an old version of tar to be in use anymore. :-P

But your output shows a more serious problem: "Unexpected EOF" means the archive is missing a piece. I sent you a patch for that bug in my previous mail.

Thanks, Rene