Re: new cvsps version fixes issues for cvs2git

From: David Mansfield <david@cobite.com>
Date: May 26, 2005, 04:35 UTC
Message-ID: <429551FB.60601@cobite.com>
In-Reply-To: <Pine.LNX.4.58.0505252111580.2307@ppc970.osdl.org>

Show 5 quoted lines

> 
> Since the CVS information doesn't contain any timezone, it would be bogus
> to use one, and the only sane git conversion is to always use UTC. Using 
> the timezone of the converter is also bogus, since that just makes 
> different converters get different results.

The cvs log is now properly handled as UTC. It wasn't before. That's one good thing. And yes, git conversion better always be UTC, no argument here.

Show 6 quoted lines

> 
> So I'd much rather see you add a flag that just always does the native CVS
> time (ie UTC)?  Quite frankly, it's wrong to do anything else, exactly
> because it makes no sense to print out dates in a timezone that has no
> relevance (what relevance does Pacitic time have for somebody who
> committed something at 8AM Eastern? _None_).

It will always print in the localtime of the user running cvsps, not the timezone of the commiter (in fact, we don't know the timezone of the committer at all). I hate committing something, running cvsps and having it tell me I'm about to commit in five hours, but I *do* see your point.

> 
> The fact is, if we depend on people doign "TZ=UTC", people will forget, 
> and then people will have different conversions.

That's true, that would be terrible. But I'm arguing that the actual conversion program (which actually wants machine readable output) should make it happen. If that means we need a shell-script wrapper than so-be-it. By letting cvsps display in any timezone, including UTC, it can work for everyone (keep the policy out of the program).

> (My personal preference would be to _default_ to UTC, and instead have a
> special flag that says "use localtime to print stuff out", since 
> localtime really is the least relevant one most of the time)
>

The thing you may be missing (and, hey, why not?) is that some people will actually still be using cvs, and cvsps to them is a tool that produces output for humans. For you, it is a stone in the path to git's domination of the world.

I'll have to think about it. At the very least a flag requesting UTC, or a flag requesting localtime makes sense. Setting environment variables and then running a program always seemed a bit like abuse of global variables.

David