Re: [PATCH GIT 0.6] make use of register variables & size_t

From: Matthias-Christian Ott <matthias.christian@tiscali.de>
Date: Apr 25, 2005, 16:59 UTC
Message-ID: <426D21FE.3040401@tiscali.de>
In-Reply-To: <Pine.LNX.4.58.0504250751330.18901@ppc970.osdl.org>

Linus Torvalds wrote:

Show 16 quoted lines

> 
> On Mon, 25 Apr 2005, Matthias-Christian Ott wrote:
> 
>>The "git" didn't try store small variables, which aren't referenced, in 
>>the processor registers. It also didn't use the size_t type. I corrected 
>>a C++ style comment too.
> 
> 
> What kind of ancient C standard are you working against?
> 
> // isn't "C++" any more, and "register" variables are sooo 60's, man.
> 
> Pass the toke,
> 
> 		Linus
>

"register" and "auto" variables aren't relicts of the 60's, they're a part of the ISO-C 99 standard, I'm following, "man".

And if you think "register" variables are outdated, please remove the CONFIG_REGPARM option from the Kernel source.

Removing a "//" comment makes sense in this case because a "//" comment between hundrets of "/* */" comments looks extremly ugly and shows that the source is "patchworked" and unstructured.

Today a lot of people forget about the basic rules of coding. You too. :)

Matthias-Christian Ott

Literature: [1] Dr.-Ing. Ludwig Claßen, Dipl.-Math. Ulrich Oefler: Unix und C: Ein Anwenderbuch; VEB Verlag Technik Berlin; 1990 [2] Erik de Castro Lopo, Peter Aitken, Bradley L. Jones: Teach Yourself C for Linux Programming in 21 Days; SAMS Publishing; 1999