Re: Single brackets matching in .gitignore rules

From: Andrey Loskutov <loskutov@gmx.de>
Date: Sep 28, 2015, 17:46 UTC
Message-ID: <4259524.1vtm9ffbuH@pinguin>
In-Reply-To: <xmqq7fnae92a.fsf@gitster.mtv.corp.google.com>

On Monday 28 September 2015 10:40 Junio C Hamano wrote:

Show 12 quoted lines

> Duy Nguyen <pclouds@gmail.com> writes:
> 
> > This is already answered. I just want to add that C Git has stopped
> > using system fnmatch for some time (part of the reason is system
> > fnmatch behaves differently in corner cases). If you don't mind C,
> > have a look at dowild() in wildmatch.c, or t/t3070-wildmatch.sh for
> > some corner cases (but your cases aren't there, may be worth adding
> > too)
> 
> What exactly are you suggesting to "fix", though?  Barf when an
> unmatched ] appears as a part of the pattern, instead of taking it
> literally?

I would rather treat the opened but unmatched [ bracket literally, so that it works similar like ]. Originally I've implemented this "symmetrical" behavior in JGit without to know that unmatched [ and ] have different behavior in C Git.

-- 
Kind regards,
google.com/+AndreyLoskutov