git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 3/6] diff.c: make constant string arguments const

From
John Keeping <john@keeping.me.uk>
Date
Feb 7, 2013, 20:15 UTC
Message-ID
<41ec7ef2fdc2a56c43abd00ef9a48fc41b765c9b.1360267849.git.john@keeping.me.uk>
In-Reply-To
<cover.1360267849.git.john@keeping.me.uk>
Signed-off-by: John Keeping <john@keeping.me.uk>
---
 diff.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/diff.c b/diff.c
index bf95235..73ae02d 100644
--- a/diff.c
+++ b/diff.c
@@ -2123,7 +2123,8 @@ static unsigned char *deflate_it(char *data,
 	return deflated;
 }
 
-static void emit_binary_diff_body(FILE *file, mmfile_t *one, mmfile_t *two, char *prefix)
+static void emit_binary_diff_body(FILE *file, mmfile_t *one, mmfile_t *two,
+				  const char *prefix)
 {
 	void *cp;
 	void *delta;
@@ -2184,7 +2185,8 @@ static void emit_binary_diff_body(FILE *file, mmfile_t *one, mmfile_t *two, char
 	free(data);
 }
 
-static void emit_binary_diff(FILE *file, mmfile_t *one, mmfile_t *two, char *prefix)
+static void emit_binary_diff(FILE *file, mmfile_t *one, mmfile_t *two,
+			     const char *prefix)
 {
 	fprintf(file, "%sGIT binary patch\n", prefix);
 	emit_binary_diff_body(file, one, two, prefix);
-- 
1.8.1.2
Previous: John KeepingNext: John Keeping
Message 5 of 9 in “Improve "git log --graph" output of merges”
  1. 0/6 Improve "git log --graph" output of mergesJohn Keeping, Feb 7, 2013
  2. 1/6 graph: output padding for merge subsequent parentsJohn Keeping, Feb 7, 2013
  3. John KeepingFeb 8, 2013
  4. 2/6 diff: write prefix to the correct fileJohn Keeping, Feb 7, 2013
  5. 3/6 diff.c: make constant string arguments constJohn Keeping, Feb 7, 2013
  6. 4/6 diff: add diff_line_prefix functionJohn Keeping, Feb 7, 2013
  7. 5/6 diff.c: use diff_line_prefix() where applicableJohn Keeping, Feb 7, 2013
  8. 6/6 combine-diff.c: teach combined diffs about line prefixJohn Keeping, Feb 7, 2013
  9. Junio C HamanoFeb 7, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.