Re: [PATCH v2 3/5] meson: correct path to system config/attribute files
- From
Ramsay Jones <ramsay@ramsayjones.plus.com>
- Date
- May 15, 2025, 19:53 UTC
- Message-ID
- <411ba125-68f3-4874-9fce-6f9f83eabe8b@ramsayjones.plus.com>
- In-Reply-To
- <8ca4ebd7-1058-4694-ba50-baf248b45050@gentoo.org>
On 15/05/2025 18:51, Eli Schwartz wrote:
> On 5/15/25 12:42 PM, Ramsay Jones wrote:
[snip]
Show 45 quoted lines
> Well, so-so.
>
>
> eschwartz@acleverhostname ~/git/git $ meson configure .
>
> meson.build:208:0: ERROR: None of values [] are supported by the C
> compiler. Possible values for option "C_std" are ['none', 'c89', 'c99',
> 'c11', 'c17', 'c18', 'c2x', 'c23', 'gnu89', 'gnu99', 'gnu11', 'gnu17',
> 'gnu18', 'gnu2x', 'gnu23']
>
>
> But also,
>
> $ sed -i '/c_std=/d' meson.build && PAGER=cat COLUMNS=80 meson configure .
>
> WARNING: The source directory instead of the build directory was specified.
> WARNING: Only the default values for the project are printed.
>
> Core properties:
> Source dir /home/eschwartz/git/git
>
> Main project options:
>
> Core options Default Value Possible Values
> Description
> -------------- ------------- ---------------
> -----------
> auto_features auto [enabled, disabled, Override
> value of
> auto] all
> 'auto'
> features
>
>
> [...]
>
>
> I'm not completely certain why this evaluates as an empty node:
>
> ```(meson.version().version_compare('>=1.3.0') ? 'gnu99,c11' : 'gnu99')
> ```
>
>
> but it (meson configure) is part of the AST interpreter, not the runtime
> one, which I know less about...Ah, interesting. When it came time to test this patch, I spent about half an hour trying to get 'meson configure' to tell me about the project options, because I had a distant memory of having done it before at one point ... :)
Hmm, maybe it was before commit 13cb20fc46 ("meson: fix compilation with Visual Studio", 2025-01-22). If I (effectively) revert that commit, then 'meson configure' works fine for me (you don't even need the '.').
TIL. Thanks!
ATB, Ramsay Jones