Re: [PATCH 2/2] add NORETURN_PTR for function pointers
- From
Erik Faye-Lund <kusmabite@googlemail.com>
- Date
- Oct 1, 2009, 16:57 UTC
- Message-ID
- <40aa078e0910010957q4daf104cja218af3aa5424637@mail.gmail.com>
- In-Reply-To
- <20091001081710.GC13436@coredump.intra.peff.net>
On Thu, Oct 1, 2009 at 1:17 AM, Jeff King <peff@peff.net> wrote:
> Thanks, this version and (your 1/2) both look sane to me. The only thing > missing are some Makefile knobs to tweak this, but I will assume that > will come as part of a later MSVC-compatibility series.
Thanks for reviewing :)
I sent an additional patch to the msysgit mailing-list that defines NORETURN for MSVC, but I think it's better to keep it out of git.git for a little while. There's no Makefile-knobs, it checks for _MSC_VER (similar to what's done for GCC).
-- Erik "kusma" Faye-Lund kusmabite@gmail.com (+47) 986 59 656