Re: [PATCH 2/2] remove NORETURN from function pointers
- From
Erik Faye-Lund <kusmabite@googlemail.com>
- Date
- Sep 25, 2009, 13:56 UTC
- Message-ID
- <40aa078e0909250656j4b791a99naf632b5b8d8e1038@mail.gmail.com>
- In-Reply-To
- <7v1vlyrcef.fsf@alter.siamese.dyndns.org>
On Tue, Sep 22, 2009 at 9:46 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 22 quoted lines
> Johannes Sixt <j.sixt@viscovery.net> writes: > >> Erik Faye-Lund schrieb: >>> On Mon, Sep 14, 2009 at 3:19 PM, Johannes Sixt <j.sixt@viscovery.net> wrote: >>>> "The" warning? Not "the two" warnings? Then I suggest to stop here; MSVC >>>> is only half-competent with regards to noreturn. >>> >>> There was only one warning in this regard on MSVC - the one about >>> unreachable code. And yes, MSVC is only half-competent, but it seems >>> it's competence is in the half that matters in our case. >>> >>> Do you suggest to stop the patch-series, or to stop the testing? >> >> My suggestion was about stopping the patch series. >> >> But thinking a bit more about it, I can imagine that there are calls to >> die() that, if it is not marked noreturn, could trigger other warnings >> with MSVC. That would be annoying, and it's better to mark it noreturn. >> >> So I withdraw my suggestion to stop :-) > > Anything happened to this series?
No, I'm sorry for not updating. I'm currently on vacation, and I didn't get time to fix it up before going, due to my dayjob. I'll pick it up again as soon as I get back home, in a bit more than a week.
-- Erik "kusma" Faye-Lund kusmabite@gmail.com (+47) 986 59 656