git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 1/8] merge-recursive: remove dead conditional in update_stages()

From
Thomas Rast <tr@thomasrast.ch>
Date
Sep 6, 2014, 17:56 UTC
Message-ID
<407c0fe475316267949c3043d8e6457ae793835c.1409860234.git.tr@thomasrast.ch>
In-Reply-To
<cover.1409860234.git.tr@thomasrast.ch>
From: Thomas Rast <trast@inf.ethz.ch>

650467c (merge-recursive: Consolidate different update_stages functions, 2011-08-11) changed the former argument 'clear' to always be true. Remove the useless conditional.

Signed-off-by: Thomas Rast <trast@inf.ethz.ch>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 merge-recursive.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/merge-recursive.c b/merge-recursive.c
index 1d332b8..4459607 100644
--- a/merge-recursive.c
+++ b/merge-recursive.c
@@ -547,11 +547,9 @@ static int update_stages(const char *path, const struct diff_filespec *o,
 	 * would_lose_untracked).  Instead, reverse the order of the calls
 	 * (executing update_file first and then update_stages).
 	 */
-	int clear = 1;
 	int options = ADD_CACHE_OK_TO_ADD | ADD_CACHE_SKIP_DFCHECK;
-	if (clear)
-		if (remove_file_from_cache(path))
-			return -1;
+	if (remove_file_from_cache(path))
+		return -1;
 	if (o)
 		if (add_cacheinfo(o->mode, o->sha1, path, 1, 0, options))
 			return -1;
-- 
2.1.0.72.g9b94086
Previous: Thomas RastNext: Thomas Rast
Message 2 of 18 in “--remerge-diff”
  1. 0/8 --remerge-diffThomas Rast, Sep 6, 2014
  2. 1/8 merge-recursive: remove dead conditional in update_stages()Thomas Rast, Sep 6, 2014
  3. 2/8 merge-recursive: internal flag to avoid touching the worktreeThomas Rast, Sep 6, 2014
  4. Junio C HamanoSep 8, 2014
  5. 3/8 merge-recursive: -Xindex-only to leave worktree unchangedThomas Rast, Sep 6, 2014
  6. 4/8 combine-diff: do not pass revs->dense_combined_merges redundantlyThomas Rast, Sep 6, 2014
  7. Junio C HamanoSep 8, 2014
  8. Jens LehmannSep 11, 2014
  9. 5/8 Fold all merge diff variants into an enumThomas Rast, Sep 6, 2014
  10. Junio C HamanoSep 8, 2014
  11. 6/8 merge-recursive: allow storing conflict hunks in indexThomas Rast, Sep 6, 2014
  12. Junio C HamanoSep 9, 2014
  13. 7/8 name-hash: allow dir hashing even when !ignore_caseThomas Rast, Sep 6, 2014
  14. Junio C HamanoSep 9, 2014
  15. 8/8 log --remerge-diff: show what the conflict resolution changedThomas Rast, Sep 6, 2014
  16. Junio C HamanoSep 8, 2014
  17. Junio C HamanoSep 9, 2014
  18. Junio C HamanoSep 9, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.