Re: [PATCH v2 1/2] rebase: use test_commit helper in setup
- From
- Phillip Wood <phillip.wood123@gmail.com>
- Date
- Mar 14, 2022, 10:52 UTC
- Message-ID
- <4072d712-4138-6cf0-e0e0-5a3303ce010a@gmail.com>
- In-Reply-To
- <xmqqee36watb.fsf@gitster.g>
On 13/03/2022 07:50, Junio C Hamano wrote:
Show 16 quoted lines
> "John Cai via GitGitGadget" <gitgitgadget@gmail.com> writes: > >> From: John Cai <johncai86@gmail.com> >> >> To prepare for the next commit that will test rebase with oids instead >> of branch names, update the rebase setup test to add a couple of tags we >> can use. This uses the test_commit helper so we can replace some lines >> that add a commit manually. > > OK. > >> test_expect_success 'prepare repository with topic branches' ' >> - git config core.logAllRefUpdates true && > > This lossage is not explained. I do not know if we actually make > use of the reflog in the tests, though.
It is the default these days so we don't need to waste a process setting it here.
Best Wishes
Phillip