Re: [PATCH] rebase -i: Add missing newline to end of message

From: Phillip Wood <phillip.wood@talktalk.net>
Date: May 19, 2017, 10:13 UTC
Message-ID: <406d017b-b138-72db-d5ad-14ccf5d1f3d4@talktalk.net>
In-Reply-To: <alpine.DEB.2.21.1.1705182321030.3610@virtualbox>

On 18/05/17 22:21, Johannes Schindelin wrote:

Show 11 quoted lines

> Hi Phillip,
> 
> On Thu, 18 May 2017, Phillip Wood wrote:
> 
>> From: Phillip Wood <phillip.wood@dunelm.org.uk>
>>
>> The message that's printed when auto-stashed changes are successfully
>> restored was missing '\n' at the end.
>> ---
> 
> Please add your Signed-off-by:, and my Acked-by:

Will do (I forgot to add --signoff to git commit). Do I need to resend the other patches with your Acked-by: or will that happen when Junio applies them?

I was thinking about this last night and wonder if it would be better to do

- printf(_("Applied autostash.")); + printf("%s\n", _("Applied autostash."));

rather than

- printf(_("Applied autostash.")); + printf(_("Applied autostash.\n"));

as it would avoid changing the translated string and also mean that the newline couldn't be accidentally removed any typos in the translation.

Best Wishes

Phillip