Re: [PATCH v3] diff: make diff_free_filespec_data accept NULL

From: Jinoh Kang <luke1337@theori.io>
Date: Nov 10, 2020, 14:21 UTC
Message-ID: <406549bb-1ab6-eb8a-7383-4715666071f9@theori.io>
In-Reply-To: <nycvar.QRO.7.76.6.2011101257540.18437@tvgsbejvaqbjf.bet>

On 11/10/20 1:16 PM, Jinoh Kang wrote:

Show 9 quoted lines

> On 11/10/20 12:08 PM, Johannes Schindelin wrote:
>> I am unaware of any other commit having a `Fixes:` trailer in the commit
>> message. In any case, I would have expected `Fixes:` to mention a ticket
>> or a bug report, not the commit that fixed _a separate_ issue (but
>> unfortunately introduced this regression).
> 
> Sorry for this one; somehow I didn't notice that git and linux use
> different conventions.
>

After leaving it out, I realized there are actually five commits using "Fixes: <commit>":

    $ git log --oneline --grep='Fixes: [0-9a-f]\{8,\} (".*")' master
    e2bfa50ac3 pack-write/docs: update regarding pack naming
    7328482253 repack: disable bitmaps-by-default if .keep files exist
    ba3a08ca0e fsck: fix leak when traversing trees
    5cae73d5d2 http: release strbuf on disabled alternates
    c22f620205 xread: retry after poll on EAGAIN/EWOULDBLOCK

Since it's not that common, I guess it's fine to leave it as is?

-- 
Jinoh Kang
Theori