Re: [PATCH] contrib/difftool: remove distracting 'echo' in the SIGINT handler

From: David Aguilar <davvid@gmail.com>
Date: Jan 20, 2009, 03:04 UTC
Message-ID: <402731c90901191904l217d6bdenf33f02033519c731@mail.gmail.com>
In-Reply-To: <200901200041.18793.markus.heidelberg@web.de>

On Mon, Jan 19, 2009 at 3:41 PM, Markus Heidelberg <markus.heidelberg@web.de> wrote:

Show 9 quoted lines

> When interrupting git-difftool with Ctrl-C, the output of this echo
> command led to having the cursor at the beginning of the line below the
> shell prompt.
>
> Signed-off-by: Markus Heidelberg <markus.heidelberg@web.de>
> ---
>
>        David, have you intentionally added this 'echo', did it fix
>        anything for you?

I think you're right in that we're better off without the echo. There wasn't really any reason for it to be there.

Show 20 quoted lines

>
>  contrib/difftool/git-difftool-helper |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/contrib/difftool/git-difftool-helper b/contrib/difftool/git-difftool-helper
> index a2eb59b..0c48506 100755
> --- a/contrib/difftool/git-difftool-helper
> +++ b/contrib/difftool/git-difftool-helper
> @@ -32,7 +32,6 @@ cleanup_temp_files () {
>
>  # This is called when users Ctrl-C out of git-difftool-helper
>  sigint_handler () {
> -       echo
>        cleanup_temp_files
>        exit 1
>  }
> --
> 1.6.1.216.g3acd
>
>

-- 
    David