git add —ignore-errors causes --renormalize

From: Dmitriy Smirnov <dmitriy.smirnov@jetbrains.com>
Date: Jan 17, 2019, 15:22 UTC
Message-ID: <401130AF-056B-40BF-8001-8492223B8A6B@jetbrains.com>

Hello,

Calling `git add —ignore-errors` appears to be equal to calling `git add —renormalize`:

Main.java is saved with CRLF in repo git config core.autocrlf = input

$ src  git:(master) echo line >> Main.java  
$ src  git:(master) git add --ignore-errors Main.java  
$ src  git:(master) git commit -m "Ignore errors"                          
[master cf24b3b] Ignore errors
 1 file changed, 13 insertions(+), 12 deletions(-)

The reason appears to be wrong bit mask usage

#define ADD_CACHE_IGNORE_ERRORS 4 and #define HASH_RENORMALIZE 4

Looks like a regression since 2.16.0 - 9472935d81eaf9faed771878c9df0216ae0d9045