Re: Git Gui - enhancement suggestion - Can a double click on the file name in the “unstaged” area move the item to “staged changes”

From: Marc Branchaud <marcnarc@xiplink.com>
Date: Sep 13, 2019, 21:53 UTC
Message-ID: <3fac912d-9e3c-bf19-e1e5-2691a835b151@xiplink.com>
In-Reply-To: <20190913143229.5yop5oaascgavynl@yadavpratyush.com>

On 2019-09-13 10:32 a.m., Pratyush Yadav wrote:

Show 26 quoted lines

> On 13/09/19 12:24PM, Allan Ford wrote:
>> Dear Git Authors,
>>
>> Not a bug, but a suggestion consideration for “Git Gui”
>>
>> Can a double click on the file name in the “unstaged” area move the
>> item to “staged changes” .. (rather than having to click on the small
>> icon to the left of the file name?)
> 
> It has been something on my radar for some time. Shouldn't be something
> too difficult to do.
> 
> While I like the idea in general, I have a question that I'd like to ask
> other git-gui users:
> 
> If we implement something like this, what happens when you single-click
> on the icon? Do we treat that as a stage/unstage command? If we keep the
> legacy behaviour of single-click on the icon stages/unstages, then a
> part of the row is single-click and the rest double-click.
> 
> If we make an entire row of the stage/unstage widget double click, it
> messes with people who are already used to it.
> 
> Is partial single and partial double click behaviour acceptable? Or
> should we make the entire row double click only? Or something else that
> I missed?

I've always felt this was a bit of user-experience failure on git-gui's part. Single-click should not behave differently just because you click the icon. I've seen many new git-gui users find this (mildly) confusing.

I'd be happy if the click behavior was consistent across the entire row: single-click to select, double-click to stage/unstage, and there's nothing special about clicking the icon. I personally don't think it would be hard to adjust to that.

I guarantee you that if double-click support is added while preserving the icon-single-click, users will get tripped up when they double-click the icon and accidentally stage two files.

M.