Re: [PATCH 05/11] Remove va_copy at MSVC because there are va_copy.
- From
- Reece Dunn <msclrhd@googlemail.com>
- Date
- Aug 17, 2009, 16:56 UTC
- Message-ID
- <3f4fd2640908170956j556fcba7o1ec4c2107197dbd@mail.gmail.com>
- In-Reply-To
- <4A898B27.3040507@gnu.org>
2009/8/17 Paolo Bonzini <bonzini@gnu.org>:
Show 15 quoted lines
> On 08/17/2009 06:04 PM, Frank Li wrote: >> >> MSVs have not implemented va_copy. remove va_copy at MSVC environment. >> It will malloc buffer each time. > > ... but only a 257-byte buffer as dscho pointed out. > > In many places that do not have va_copy, a simple assignment works. And > va_end is almost always a no-op. So what about > > #ifndef va_copy > #define va_copy(dst, src) ((dst) = (src)) > #endif > > if it works on MSVC?
According to http://stackoverflow.com/questions/558223/vacopy-porting-to-visual-c that should work.
- Reece