git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 5/6] whitespace: add tab-in-indent support for --whitespace=fix

From
Chris Webb <chris@arachsys.com>
Date
Apr 2, 2010, 23:37 UTC
Message-ID
<3edb43ab524b6b2ee883c25cfa80bc6012a4abd4.1270250437.git.chris@arachsys.com>
In-Reply-To
<cover.1270250437.git.chris@arachsys.com>

If tab-in-indent is set, --whitespace=fix will ensure that any stray tabs in the initial indent are expanded to the correct number of space characters.

Signed-off-by: Chris Webb <chris@arachsys.com>
---
 ws.c |   21 ++++++++++++++++++---
 1 files changed, 18 insertions(+), 3 deletions(-)
diff --git a/ws.c b/ws.c
index 897ff56..e581535 100644
--- a/ws.c
+++ b/ws.c
@@ -313,8 +313,9 @@ void ws_fix_copy(struct strbuf *dst, const char *src, int len, unsigned ws_rule,
 		char ch = src[i];
 		if (ch == '\t') {
 			last_tab_in_indent = i;
-			if ((ws_rule & WS_SPACE_BEFORE_TAB) &&
-			    0 <= last_space_in_indent)
+			if ((ws_rule & WS_TAB_IN_INDENT) ||
+			    ((ws_rule & WS_SPACE_BEFORE_TAB) &&
+			     0 <= last_space_in_indent))
 			    need_fix_leading_space = 1;
 		} else if (ch == ' ') {
 			last_space_in_indent = i;
@@ -325,7 +326,21 @@ void ws_fix_copy(struct strbuf *dst, const char *src, int len, unsigned ws_rule,
 			break;
 	}
 
-	if (need_fix_leading_space) {
+	if ((ws_rule & WS_TAB_IN_INDENT) && last_tab_in_indent >= 0) {
+		/* Expand tabs into spaces */
+		int last = last_tab_in_indent + 1;
+		for (i = 0; i < last; i++) {
+			if (src[i] == '\t')
+				do {
+					strbuf_addch(dst, ' ');
+				} while (dst->len % 8);
+			else
+				strbuf_addch(dst, src[i]);
+		}
+		len -= last;
+		src += last;
+		fixed = 1;
+	} else if (need_fix_leading_space) {
 		/* Process indent ourselves */
 		int consecutive_spaces = 0;
 		int last = last_tab_in_indent + 1;
-- 
1.7.0.3
Previous: Chris WebbNext: Chris Webb
Message 7 of 8 in “Add tab-in-indent whitespace rule”
  1. 0/6 Add tab-in-indent whitespace ruleChris Webb, Apr 2, 2010
  2. 1/6 whitespace: we cannot "catch all errors known to git" anymoreChris Webb, Apr 2, 2010
  3. 2/6 whitespace: add tab-in-indent error classChris Webb, Apr 2, 2010
  4. Martin MaresApr 3, 2010
  5. 3/6 whitespace: tests for git-diff --check with tab-in-indent error classChris Webb, Apr 2, 2010
  6. 4/6 whitespace: replumb ws_fix_copy to take a strbuf *dst instead of char *dstChris Webb, Apr 2, 2010
  7. 5/6 whitespace: add tab-in-indent support for --whitespace=fixChris Webb, Apr 2, 2010
  8. 6/6 whitespace: tests for git-apply --whitespace=fix with tab-in-indentChris Webb, Apr 2, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.