git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 1/2] notes: update documentation for `use_default_notes`

From
Kristoffer Haugsbakk <code@khaugsbakk.name>
Date
Jun 4, 2023, 18:53 UTC
Message-ID
<3eaa725d3a476e3cfd7331104f35bbd322d9394f.1685904424.git.code@khaugsbakk.name>
In-Reply-To
<cover.1685904424.git.code@khaugsbakk.name>

`suppress_default_notes` was renamed to `use_default_notes` in 3a03cf6b1d (notes: refactor display notes default handling, 2011-03-29).

The commit message says that “values less than one [indicates] “not set” ”, but what was meant was probably “less than zero” (the author of 3a03cf6b1d agrees on this point).

Signed-off-by: Kristoffer Haugsbakk <code@khaugsbakk.name>
---
 notes.h | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/notes.h b/notes.h
index c1682c39a9..a823840e49 100644
--- a/notes.h
+++ b/notes.h
@@ -286,8 +286,9 @@ void disable_display_notes(struct display_notes_opt *opt, int *show_notes);
  * If 'opt' is not NULL, then it specifies additional settings for the
  * displaying:
  *
- * - suppress_default_notes indicates that the notes from
- *   core.notesRef and notes.displayRef should not be loaded.
+ * - use_default_notes: less than `0` is "unset", which means that the
+ *   default notes are shown iff no other notes are given. Otherwise,
+ *   treat it like a boolean.
  *
  * - extra_notes_refs may contain a list of globs (in the same style
  *   as notes.displayRef) where notes should be loaded from.
-- 
2.41.0
Previous: Kristoffer HaugsbakkNext: Kristoffer Haugsbakk
Message 9 of 13 in “notes: update documentation for `use_default_notes`”
  1. notes: update documentation for `use_default_notes`Kristoffer Haugsbakk, May 31, 2023
  2. notes: update documentation for `use_default_notes`Kristoffer Haugsbakk, May 31, 2023
  3. Jeff KingJun 1, 2023
  4. Kristoffer HaugsbakkJun 2, 2023
  5. 0/2 notes: update documentation for `use_default_notes`Kristoffer Haugsbakk, Jun 4, 2023
  6. 2/2 notes: move the documentation to the structKristoffer Haugsbakk, Jun 4, 2023
  7. Jeff KingJun 5, 2023
  8. Kristoffer HaugsbakkJun 5, 2023
  9. 1/2 notes: update documentation for `use_default_notes`Kristoffer Haugsbakk, Jun 4, 2023
  10. 0/2 notes: update documentation for `use_default_notes`Kristoffer Haugsbakk, Jun 5, 2023
  11. 1/2 notes: update documentation for `use_default_notes`Kristoffer Haugsbakk, Jun 5, 2023
  12. 2/2 notes: move the documentation to the structKristoffer Haugsbakk, Jun 5, 2023
  13. Jeff KingJun 6, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.