Re: [PATCH] gitweb: More detailed error messages for snapshot format

From: Matt McCutchen <hashproduct@gmail.com>
Date: Jul 24, 2007, 21:50 UTC
Message-ID: <3bbc18d20707241450y48ef0485i2809c632ac2e643@mail.gmail.com>
In-Reply-To: <11853108372532-git-send-email-jnareb@gmail.com>

On 7/24/07, Jakub Narebski <jnareb@gmail.com> wrote:

Show 8 quoted lines

> Improve error messages for snapshot format in git_snapshot:
> distinguish between situation where snapshots are turned off, where
> snapshot format ('sf') parameter is invalid, where given snapshot
> format does not exist in %known_snapshot_formats hash, and where
> gitweb was given unsupported snapshot format.
>
> While at it, use first from all supported snapshots format as default,
> if no snapshot format was provided.

I tested the patch and it worked properly: the errors appeared at the appropriate times and the first supported format was used as the default.

I also noticed that the check for an "invalid" format requires that it contain at least one good character, not that it contain no bad characters, which was what I originally meant. It would be nice to fix the check, or the check could even be removed altogether since gitweb refuses any format that isn't in %known_snapshot_formats . (I think I was misguidedly paranoid to add it in the first place.)