Re: [PATCH 0/8] Various fixes for v2.45.1 and friends

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: May 18, 2024, 00:02 UTC
Message-ID: <3b140a63-ddb1-bd84-94c5-51e39d60c011@gmx.de>
In-Reply-To: <xmqqa5kodmil.fsf@gitster.g>

Hi Junio and brian,

On Fri, 17 May 2024, Junio C Hamano wrote:

Show 16 quoted lines

> "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
> writes:
>
> > There have been a couple of issues that were reported about v2.45.1, and in
> > addition I have noticed some myself:
> >
> >  * a memory leak in the clone protection logic
> >  * a missed adjustment in the Makefile that leads to an incorrect templates
> >    path in v2.39.4, v2.40.2 and v2.41.1 (but not in v2.42.2, ..., v2.45.1)
> >  * an overzealous core.hooksPath check
> >  * that Git LFS clone problem where it exits with an error (even if the
> >    clone often succeeded...)
>
> I thought brian expressed an interest in the issues these patches
> attempt to address, so I thought it is helpful to Cc them to his
> attention.

oh my. I forgot to add the Cc (I guess I should have slept first, but I wanted to get this out so that the Git LFS breakage as well as the other breakages could be addressed as swiftly as possible)!

I really meant to Cc: you, brian, hoping for your substantial expertise and kind code reviews to help get this landed soonish, in a shape that makes Git better, and hopefully averts more breakages.

> > This patch series is based on maint-2.39 to allow for (relatively) easy
> > follow-up versions v2.39.5, ..., v2.45.2.
>
> Thanks for basing them on the oldest version that is relevant.

I also meant to provide `maint-*` branches but basically ran out of time. Will work on that next week. I expect quite a few merge conflicts.

Ciao, Johannes