Re: [PATCH/RFC 2/2] grep: rename "grep.extendedRegexp" option to "grep.patternType"

From: J Smith <dark.panda@gmail.com>
Date: Aug 1, 2012, 03:38 UTC
Message-ID: <3D9678D0-DD72-4538-81E8-7568A2A3211D@gmail.com>
In-Reply-To: <7vpq7bh5wx.fsf@alter.siamese.dyndns.org>

On 2012-07-31, at 7:22 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 15 quoted lines

> J Smith <dark.panda@gmail.com> writes:
> 
>> With the addition of the "basic", "extended", "fixed", and "perl"
>> values for the "grep.extendedRegexp" option the name "grep.patternType"
>> better represents the option's functionality. "grep.extendedRegexp"
>> remains available as an alias to "grep.patternType" for the purposes of
>> backwards compatibility.
>> ---
> 
> Sorry for not bringing this up earlier when we discussed grep.patternType,
> but my preference would be to introduce grep.patternType with these
> type names (including basic and perl) from the beginning, and then
> ignore grep.extendedRegexp if grep.patternType is set.
> 
> The core part of the change may look something like this...

Ah, I see. Yeah, that's not a problem. I'll make the appropriate changes tomorrow and post a new patch.