Re: [PATCH] git-rebase--interactive.sh: Add new command "shell"

From: Kevin Ballard <kevin@sb.org>
Date: Nov 4, 2010, 21:33 UTC
Message-ID: <3B610A5B-DE74-4DB1-A61D-13AAF167E36C@sb.org>
In-Reply-To: <20101104205307.GA8911@home.lan>

On Nov 4, 2010, at 1:53 PM, Yann Dirson wrote:

Show 9 quoted lines

> Eric Raible suggested:
>> How about:
>> 
>> #  e [<commit>], edit [<commit>] = use commit (if present) but pause to amend
> 
> Other commands do not mention commit (or other things) as a synopsis would.
> What about:
> 
> #  e, edit = use commit (if specified) but pause to amend/examine/test

I like this. My only remaining concern is the original "shell" version let you put in a comment (though this was not yet documented) that would be printed when you were sent back to the shell. This was a useful reminder as to what step you were on. But when we overload "edit", this functionality is lost. I won't fight for it if nobody else here thinks it's worthwhile, but I did want to point that out.

-Kevin Ballard