Re: [PATCH] darwin: Use CommonCrypto to compute SHA1
- From
- Geert Bosch <bosch@adacore.com>
- Date
- Mar 10, 2010, 04:00 UTC
- Message-ID
- <392914AB-CF6D-4094-969D-6057608F86F8@adacore.com>
- In-Reply-To
- <9AE94716-A53B-40A6-A7D9-CCD39B820390@apple.com>
On Mar 9, 2010, at 19:01, Jeremy Huddleston wrote:
Show 23 quoted lines
> From: Jeremy Huddleston <jeremyhu@apple.com> > Date: Mon, 8 Mar 2010 15:10:54 -0800 > Subject: [PATCH] darwin: Use CommonCrypto to compute SHA1 > > Signed-off-by: Jeremy Huddleston <jeremyhu@apple.com> > Reviewed-by: Kevin Van Vechten <kvv@apple.com> > --- > Makefile | 14 ++++++++++++++ > cache.h | 7 +++++++ > 2 files changed, 21 insertions(+), 0 deletions(-) > > diff --git a/Makefile b/Makefile > index f64610a..bb4a1f0 100644 > --- a/Makefile > +++ b/Makefile > @@ -91,6 +91,10 @@ all:: > # Define PPC_SHA1 environment variable when running make to make use of > # a bundled SHA1 routine optimized for PowerPC. > # > +# Define COMMONCRYPTO_SHA1 environment variable when running make to make > +# use of the Darwin/Mac OS X Common Cryptography library for SHA1 > +# computation (instead of libcrypto). > +#
You're missing an argument of why this would be an improvement over the status quo. If the argument is performance, you'd better show some convincing numbers, both of SHA-1 heavy tasks and situations where program initialization is an important factor.
By default, increasing the number of different ways we use to compute the SHA1 is a negative development. There has to be a strong reason to do so, such as: for my workload X this saves me Y seconds each time I do Z.
-Geert