Re: Why doesn't git-apply remove empty file

From: Francis Moreau <francis.moro@gmail.com>
Date: Aug 14, 2008, 20:17 UTC
Message-ID: <38b2ab8a0808141317i158e13fel102cdb7e880d5d7@mail.gmail.com>
In-Reply-To: <alpine.LFD.1.10.0808141246190.3324@nehalem.linux-foundation.org>

On Thu, Aug 14, 2008 at 9:57 PM, Linus Torvalds <torvalds@linux-foundation.org> wrote:

Show 16 quoted lines

>
> The thing is, "patch" is a total piece of utterly unbelievable SH*T.
>
> git-apply acts differently, yes, but it acts differently for a damn good
> reason. No, you cannot replace git-apply with that horrible crap that is
> GNU patch.
>
> Some of the reasons are purely trivial implementation issues:
>
>  - git-apply knows about the index, and knows about updating it properly,
>   including tracking new files automatically.
>
> That's an important thing, but yeah, it's an implementation issue.
>
> The other things that git-apply do right are much more fundamental:
>

agreed with all of them...

> So no. There's no way in hell that git am should use GNU patch.
>

Just for clarification, I'm not saying to replace git-apply by patch in git-am !

But in few situations it might be better to use GNU patch for git-am. So we could have such option:

              $ git am --applier="/usr/bin/patch" ...

thanks

-- 
Francis