Re: [PATCH 2/2] pull: use git-rev-parse --parseopt for option parsing
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- May 18, 2015, 14:43 UTC
- Message-ID
- <389cf040410c499b2f382bfbcdb526d4@www.dscho.org>
- In-Reply-To
- <1431957296-31534-3-git-send-email-pyokagan@gmail.com>
Hi Paul,
On 2015-05-18 15:54, Paul Tan wrote:
Show 16 quoted lines
> diff --git a/git-pull.sh b/git-pull.sh > index 633c385..67f825c 100755 > --- a/git-pull.sh > +++ b/git-pull.sh > @@ -4,13 +4,53 @@ > # > # Fetch one or more remote refs and merge it/them into the current HEAD. > > -USAGE='[-n | --no-stat] [--[no-]commit] [--[no-]squash] > [--[no-]ff|--ff-only] [--[no-]rebase|--rebase=preserve] [-s > strategy]... [<fetch-options>] <repo> <head>...' > -LONG_USAGE='Fetch one or more remote refs and integrate it/them with > the current HEAD.' > SUBDIRECTORY_OK=Yes > -OPTIONS_SPEC= > +OPTIONS_KEEPDASHDASH=Yes
I have to admit that I was puzzled by this at first. But it seems that the intention is to handle a dashdash argument as an error, therefore we have to keep it. Is my understanding correct?
Ciao, Dscho