Re: [RFC PATCH] Windows: Assume all file names to be UTF-8 encoded.

From

Dmitry Potapov <dpotapov@gmail.com>

Date

Mar 3, 2009, 09:43 UTC

Message-ID

<37fcd2780903030143t7abe33d5sb7d8163c3c9bf505@mail.gmail.com>

In-Reply-To

<alpine.DEB.2.00.0903020941120.17877@perkele.intern.softwolves.pp.se>

On Mon, Mar 02, 2009 at 09:47:22AM +0100, Peter Krefting wrote:

> When opening a file through open() or fopen(), the path passed is
> UTF-8 encoded. To handle this on Windows, we need to convert the
> path string to UTF-16 and use the Unicode-based interface.

IMHO, you grossly underestimate what is needed to enable UTF-8 encoding
in Windows. AFAIK, Microsoft C runtime library does not support UTF-8,
so you have to wrap all C functions taking 'char*' as an input parameter.
For example, think about what is going to happen if Git tries to print
a simple error message:
  fprintf (stderr, "unable to open %s", path);

> Since there is no real file system abstraction beyond using stdio_
> (AFAIK), I need to hack it by replacing fopen (and open). Probably_
> opendir/readdir as well (might be trickier), and possibly even hack_
> around main() to parse the wchar_t command-line instead of the char copy.

Dmitry