git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v5 1/3] tests: move test_lazy_prereq JGIT to test-lib.sh

From
JTJonathan Tan <jonathantanmy@google.com>
Date
Sep 9, 2016, 20:17 UTC
Message-ID
<37c4e775948b88b2d5af1caee3a70e36f00bc88a.1473452153.git.jonathantanmy@google.com>
In-Reply-To
<cover.1473452153.git.jonathantanmy@google.com>

This enables JGIT to be used as a prereq in invocations of test_expect_success (and other functions) in other test scripts.

Signed-off-by: Jonathan Tan <jonathantanmy@google.com>
---
 t/t5310-pack-bitmaps.sh | 4 ----
 t/test-lib.sh           | 4 ++++
 2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/t/t5310-pack-bitmaps.sh b/t/t5310-pack-bitmaps.sh
index 3893afd..1e376ea 100755
--- a/t/t5310-pack-bitmaps.sh
+++ b/t/t5310-pack-bitmaps.sh
@@ -158,10 +158,6 @@ test_expect_success 'pack with missing parent' '
 	git pack-objects --stdout --revs <revs >/dev/null
 '
 
-test_lazy_prereq JGIT '
-	type jgit
-'
-
 test_expect_success JGIT 'we can read jgit bitmaps' '
 	git clone . compat-jgit &&
 	(
diff --git a/t/test-lib.sh b/t/test-lib.sh
index d731d66..c9c1037 100644
--- a/t/test-lib.sh
+++ b/t/test-lib.sh
@@ -1072,6 +1072,10 @@ test_lazy_prereq NOT_ROOT '
 	test "$uid" != 0
 '
 
+test_lazy_prereq JGIT '
+	type jgit
+'
+
 # SANITY is about "can you correctly predict what the filesystem would
 # do by only looking at the permission bits of the files and
 # directories?"  A typical example of !SANITY is running the test
-- 
2.8.0.rc3.226.g39d4020
Previous: Jonathan TanNext: Jonathan Tan
Message 3 of 5 in “handle empty spec-compliant remote repos correctly”
  1. 0/3 handle empty spec-compliant remote repos correctlyJonathan Tan, Sep 9, 2016
  2. 2/3 connect: tighten check for unexpected early hang upJonathan Tan, Sep 9, 2016
  3. 1/3 tests: move test_lazy_prereq JGIT to test-lib.shJonathan Tan, Sep 9, 2016
  4. 3/3 connect: advertized capability is not a refJonathan Tan, Sep 9, 2016
  5. Jonathan NiederSep 9, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.