BUG in gitk (was: Re: BUG: git-svn does not escape literal backslashes in author names.)

From: Benoit Sigoure <tsuna@lrde.epita.fr>
Date: Nov 17, 2007, 20:18 UTC
Message-ID: <37A0587D-2C1A-4180-A724-2E7B338465D9@lrde.epita.fr>
In-Reply-To: <1213a9470711120628l4ccab632n17635295ec897a2@mail.gmail.com>

On Nov 12, 2007, at 3:28 PM, Adrian Wilkins wrote:

Show 13 quoted lines

> Recently converted a large (11,000+ revisions) repository.
>
> We authenticate against the NT domain controller, so all our revision
> authors are of the form "domain\user". (You can switch off mod_sspi
> reporting the domain part, but I didn't know about this at the time,
> so it continues for historical reasons.)
>
> git-svn treats the literal backslashes in the author names as escapes.
> This leads to authors like
>
> domainkevin
> domain\
> ichard

Hi Adrian, I tried to reproduce the error but didn't succeed (see below). Which version of Git did you use?

However, gitk fails to properly render the various properties when they contain backslash sequences. If a gitk expert could have a look, I tried but didn't find a standard Tcl procedure to escape everything properly and I didn't feel like recoding my own procedure because I guess this already exists...

Cheers,

$ svnadmin create repo $ svn co file://`pwd`/repo wc Checked out revision 0. $ cd wc $ svn mkdir trunk tags branches A trunk A tags A branches $ svn ci -m stdlayout Adding branches Adding tags Adding trunk

Committed revision 1.
$ cd trunk
$ touch plop && svn add plop
A         plop
$ svn ci -m test --username 'domain\name\richard\test\\ok'
Adding         trunk/plop
Transmitting file data .
Committed revision 2.
$ cd ../..
$ git svn clone --stdlayout file://`pwd`/repo git
Initialized empty Git repository in .git/
r1 = dc86087745d9b6378114f49c1e480d178cf328f9 (trunk)
         A       plop
r2 = de5affcfdc897bfa77a2402a447771f0a88b04bf (trunk)
Checked out HEAD:
   file:///tmp/repo/trunk r2
$ cd git
$ git log
commit de5affcfdc897bfa77a2402a447771f0a88b04bf
Author: domain\name\richard\test\\ok <domain\name\richard\test\ 
\ok@e88f2f36-2641-46fb-97e4-5fd9951470b2
Date:   Sat Nov 17 12:17:29 2007 +0000

     test

     git-svn-id: file:///tmp/repo/trunk@2  
e88f2f36-2641-46fb-97e4-5fd9951470b2

commit dc86087745d9b6378114f49c1e480d178cf328f9
Author: tsuna <tsuna@e88f2f36-2641-46fb-97e4-5fd9951470b2>
Date:   Sat Nov 17 12:16:29 2007 +0000

     stdlayout

     git-svn-id: file:///tmp/repo/trunk@1  
e88f2f36-2641-46fb-97e4-5fd9951470b2
$ gitk # Oops

-- 
Benoit Sigoure aka Tsuna
EPITA Research and Development Laboratory