Re: [PATCH] doc git: multivar configuration parameters append to existing values

From: Philip Oakley <philipoakley@iee.org>
Date: Jun 16, 2014, 19:42 UTC
Message-ID: <3757CE4412D345B6BE1E515F8764747D@PhilipOakley>
In-Reply-To: <539F38DF.3090004@gmail.com>

From: "Tanay Abhra" <tanayabh@gmail.com>

Show 10 quoted lines

> On 06/16/2014 05:49 AM, Philip Oakley wrote:
>
>>  Pass a configuration parameter to the command. The value
>> - given will override values from configuration files.
>> + given will override single valued variables from configuration
>> + files, and append to multivar variables. Previous multivar values
>
> Nit: Forgive me if I am wrong, but `, and` is used for joining two 
> independent
> clauses. It would be better to drop the comma.

I just wrote it in my local style ;-) I was sort of treating them as independent, but see Junio's comments in a similar vein.

Show 15 quoted lines

>
>> + remain in effect. Use "insteadOf" style config variables when an
>> + over-ride is needed.
>>  The <name> is expected in the same format as listed by
>>  'git config' (subkeys separated by dots).
>>
>>
>
> 'insteadOf' is a very specific approach for a general suggestion 
> because it is only
> used in url.*.insteadof in the whole codebase. Also, it has a 
> variation described in
> urls.txt as "pushinsteadof". So, if a problem such as mentioned above 
> arises in
> a different scenario 'insteadOf' cannot be used in it.

I was using it as a suggestion for the user's 'go look for an alternative' step (i.e. that there may be an alternative!)

-- Philip