git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Feature request: Reduce amount of diff in patch

From
KKES <kes-kes@yandex.ru>
Date
Nov 28, 2017, 16:09 UTC
Message-ID
<372261511885370@web21o.yandex.ru>
Hi.
I get often patches which can be minimized:
@@ -60,11 +64,8 @@ sub _get_filter {
         address    =>  { -like => \[ '?',  "%$search%" ] },
         company    =>  { -like => \[ '?',  "%$search%" ] },
         country_code =>  { '=' => \[ 'UPPER(?)' => $search ] },
-    ]);
 
-    $users =  $users->search( $filter, {
-        prefetch => { Packages => { Ips => { Subnet => { Server => 'Locality' }}}},
-    });
+    ]);
 
 
     return $users;

This patch can be minimized to:

@@ -60,11 +64,8 @@ sub _get_filter {
         address    =>  { -like => \[ '?',  "%$search%" ] },
         company    =>  { -like => \[ '?',  "%$search%" ] },
         country_code =>  { '=' => \[ 'UPPER(?)' => $search ] },
     ]);
 
-    $users =  $users->search( $filter, {
-        prefetch => { Packages => { Ips => { Subnet => { Server => 'Locality' }}}},
-    });

 
     return $users;

May you please fix the git to generate minimized patches?

Thank you
Next: Kaartic Sivaraam
Message 1 of 4 in “Feature request: Reduce amount of diff in patch”
  1. KESNov 28, 2017
  2. Kaartic SivaraamNov 28, 2017
  3. Stefan BellerDec 7, 2017
  4. Junio C HamanoDec 7, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.